Ensure dynamic Bukkit command dispatch runs on Folia entity threads#31
Open
Chwitst187 wants to merge 1 commit intomainfrom
Open
Ensure dynamic Bukkit command dispatch runs on Folia entity threads#31Chwitst187 wants to merge 1 commit intomainfrom
Chwitst187 wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
WorldEditPlugin,FoliaEntityTask, andPlayerand wire Folia checks into the dynamic command code.execute(...), whenWorldEditPlugin.getInstance().isOnFolia()and the sender is aPlayer, route the handler throughFoliaEntityTask.execute(player, ...)andjoin()the result; otherwise keep the originalowner.onCommand(...)call.tabComplete(...), apply the same Folia-safe dispatch for player senders whenregisteredWithis aCommandInspector, preserving non-Folia and non-player behavior.Testing
./gradlew :worldedit-bukkit:compileJava -x test, which failed in this environment due to an unrelated multi-project Gradle configuration error:Task with name 'build' not found in project ':worldedit-libs:cli'.Codex Task